refactor DataSource #1556
Merged
refactor DataSource #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
goekay
commented
Aug 24, 2024
goekay
commented
- make DataSource a spring bean
- move checkJavaAndMySQLOffsets() into GenericRepository
- necessary consequential changes
* make DataSource a spring bean * move checkJavaAndMySQLOffsets() into GenericRepository * necessary consequential changes
juherr
reviewed
Aug 25, 2024
| public DSLContext dslContext() { | ||
| initDataSource(); | ||
|
|
||
| public DSLContext dslContext(DataSource dataSource) { |
There was a problem hiding this comment.
You can avoid the parameter if you get bean by calling dataSource() like in many spring samples.
| @@ -52,6 +59,25 @@ public class GenericRepositoryImpl implements GenericRepository { | |||
|
|
|||
| @Autowired private DSLContext ctx; | |||
|
|
|||
| @EventListener | |||
There was a problem hiding this comment.
It is mixing repository and service layer.
Why not move the logic into a service and use a getMySQLOffsets() provided by the repository?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.