Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrations to work with latest MariaDB patch versions #1216

Closed

Conversation

slachiewicz
Copy link
Contributor

see PR #1213

https://mariadb.org/download/

The current maintained versions are:
- 10.4, 10.5, 10.6, 10.11 (maintained for 5 years)
- 10.9, 10.10, 11.0, 11.1 (maintained for one year)
- and the development version is 11.2.

Each stable version receives bug-fixes and security fixes periodically.
@goekay
Copy link
Member

goekay commented Aug 20, 2023

you are rewriting history (i.e. modifying executed migrations). this is always problematic due to existing installations and users of steve. i (we) try to make upgrades between versions seamless.

@slachiewicz
Copy link
Contributor Author

Yes I've made movements only locally to files.
This one where I've dropped and recreated FK are equally to FC existing in version before this file. So this change should be transparent I hope.

If not this way, what other options do we have?

@juherr
Copy link
Contributor

juherr commented Aug 20, 2023

@slachiewicz

It is not possible to modify migration files because the checksum of the file is stored and any modification will be considered as corruption and will break the next migrations.

If not this way, what other options do we have?

See my proposition
#1213 (comment)_

@slachiewicz slachiewicz deleted the migrations-fix branch August 20, 2023 20:30
@goekay
Copy link
Member

goekay commented Aug 20, 2023

It is not possible to modify migration files because the checksum of the file is stored and any modification will be considered as corruption and will break the next migration.

exactly. flyway keeps migration executions in a database table. by the way, there is a way to fix checksums and we used it once: https://github.com/steve-community/steve/wiki/FAQ#how-can-i-upgrade-from-1xx-to-2xx but i am hesitant when it comes to this. it is an annoyance for users and we should use this card really carefully and sparingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants