Use status code 499 for requests where the client closed the connection #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client closes the connection before a response was returned, 499 is used as status code as in nginx.
|
Hi @Alexander-N , thanks for the contribution. I was initially concerned about changing the existing behavior, but after thinking about it, it does make sense to stop counting client disconnects as 500 errors. |
|
Great, do you have a rough timeline for the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the metrics, we were seeing a lot of requests with status code 500, which we did not see in the logs. It turned out that when a client closed the connection before a response was returned, it was reported as 500.
With this change, if the client closes the connection before a response was returned, 499 is used as status code (same code as nginx uses).
I think it's not possible to handle the
http.disconnectevent inreceivesince I think there is not guarantee that it will get called.Unfortunately, I can't think of a way to test this, as the TestClient does not send
http.disconnectbut it is working for us in production.