Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

license: json-pure? #277

Closed
onlyjob opened this issue Mar 4, 2016 · 19 comments · Fixed by #278
Closed

license: json-pure? #277

onlyjob opened this issue Mar 4, 2016 · 19 comments · Fixed by #278
Assignees

Comments

@onlyjob
Copy link

onlyjob commented Mar 4, 2016

The following fragment of LICENSE file is ambiguous:

json-pure © Genki Takiuchi

Please clarify which part of ghi is copyrighted as above. Thanks.

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

Besides Alex Chesters's copyright statement is missing...

@AlexChesters
Copy link
Contributor

This will have to be answered by @stephencelis as he was the one who added that fragment to the LICENSE file.

What do you mean by Besides Alex Chesters's copyright statement is missing...?

@stephencelis
Copy link
Owner

Please clarify which part of ghi is copyrighted as above. Thanks.

GHI embeds a JSON-parsing library when compiled into a single file. A quick search on GitHub would have brought you here: https://github.com/genki/json

We should, however, be able to remove json-pure as a dependency given that Ruby has been shipping with json standard for awhile now.

@AlexChesters
Copy link
Contributor

@stephencelis, are you able to answer @onlyjob's query?

@AlexChesters
Copy link
Contributor

Where is json-pure defined as a dependency @stephencelis?

@stephencelis
Copy link
Owner

As far as adding Alex to the LICENSE file, that's really up to him ;)

Typically licenses remain bound to the original author/owner of the code, though I'm fine adding more people to it as they contribute as much as Alex has!

@stephencelis
Copy link
Owner

@AlexChesters It's embedded here:

https://github.com/stephencelis/ghi/blob/master/lib/ghi/json.rb

I'd experiment with removing it entirely, seeing what breaks, and replace the requires with require 'json'.

@AlexChesters
Copy link
Contributor

I agree with @stephencelis that licenses remain bound to the original author/owner of the code, and given that I currently have no desire to put myself in the LICENSE file I'm not planning to do anything to address that.

On the second point I'm planning to do what @stephencelis has suggested re json-pure.

AlexChesters added a commit that referenced this issue Mar 4, 2016
AlexChesters added a commit that referenced this issue Mar 4, 2016
@AlexChesters
Copy link
Contributor

Once/If #278 gets merged this issue will be resolved.

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

Thanks for quick replies everyone. :)

What do you mean by Besides Alex Chesters's copyright statement is missing...?

Well that copyright statement is missing in the LICENSE file. A something like

Copyright 2015 Alex Chesters <myemail@domain.com>

I see that there are many contributors but no copyrights are documented...
Confusing thing about compyrights is that scope of "json-pure © Genki Takiuchi" is unclear. Apparently it applies to 3rd party component unless Genki Takiuchi was also contributing to this project...

Bundled copy of json.rb should be better documented as it is difficult to identify it in source tree due to lack of licensing information. It would be great to mention its origin (e.g. project URL).

Bundled json.rb is not the same as https://github.com/genki/json which is GPL-2 licensed...

@stephencelis
Copy link
Owner

@onlyjob json-pure and its reference in the LICENSE are to be removed.

I see that there are many contributors but no copyrights are documented...

LICENSE files and copyrights do not document every contributor to a project.

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

Thanks. :)

AlexChesters added a commit that referenced this issue Mar 4, 2016
@AlexChesters
Copy link
Contributor

This has now been closed, as json-pure has now been removed from this library (as it's functionality is now provided by Ruby itself), and I have no burning desire to add myself to the LICENSE. As @stephencelis has pointed out:

LICENSE files and copyrights do not document every contributor to a project.

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

Thanks.

Lack of contributor's copyright statements is not ideal but should be acceptable...

@AlexChesters
Copy link
Contributor

As far as I'm aware it's uncommon to list contributors in the LICENSE file, so I think that's why we've decided against it here

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

It is not that uncommon to list copyrights of significant contributors in LICENSE and there is already one contributor listed. It is convenient when copyright information is in one place. Sometimes LICENSE file is reserved for canonical text of the license with list of copyright holders in README.
The question whether you guys are going to maintain copyright attributions or not.
Without contributor license agreement to transfer copyright ownership copyright holders are not limited to the only one mentioned in LICENSE. Some projects use word "authors" in copyright attribution, some maintain list of contributors for copyright purposes...

@AlexChesters
Copy link
Contributor

Anyway, I feel like we're getting carried away here. I have no desire to maintain copyright attribution so that's the main reason why the LICENSE file only contains Stephen's name

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

Fair enough, let's move on for now. Thanks.

@onlyjob
Copy link
Author

onlyjob commented Mar 4, 2016

@AlexChesters, may I ask you to tag json-less release please so I could upload it to Debian?
Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants