fix UB in direct copy

stelzo · May 24, 2024 · 09d3bef · 09d3bef
1 parent 8b26fb6
commit 09d3bef
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/rpcl2/src/lib.rs b/rpcl2/src/lib.rs
@@ -687,7 +687,7 @@ impl PointCloud2Msg {
 
                 let bytes_total = vec.len() * point_step as usize;
                 cloud.data.resize(bytes_total, u8::default());
-                let raw_data: *mut C = cloud.data.as_ptr() as *mut C;
+                let raw_data: *mut C = cloud.data.as_mut_ptr() as *mut C;
                 unsafe {
                     core::ptr::copy_nonoverlapping(
                         vec.as_ptr().cast::<u8>(),
@@ -1006,10 +1006,10 @@ impl PointData {
     #[inline]
     fn from_buffer(data: &[u8], offset: usize, datatype: FieldDatatype, endian: Endian) -> Self {
         debug_assert!(data.len() >= offset + datatype.size());
-        let bytes = [u8::default(); core::mem::size_of::<f64>()];
+        let mut bytes = [u8::default(); core::mem::size_of::<f64>()];
         unsafe {
             let data_ptr = data.as_ptr().add(offset);
-            let bytes_ptr = bytes.as_ptr() as *mut u8;
+            let bytes_ptr = bytes.as_mut_ptr() as *mut u8;
             core::ptr::copy_nonoverlapping(data_ptr, bytes_ptr, datatype.size());
         }