Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/sincospi #2687

Merged
merged 2 commits into from
Jul 28, 2024
Merged

feat: add C implementation for math/base/special/sincospi #2687

merged 2 commits into from
Jul 28, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 28, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

void stdlib_base_sincospi( const double x, double* sine, double* cosine );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 28, 2024
@Planeshifter Planeshifter self-requested a review July 28, 2024 11:55
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Jul 28, 2024
Planeshifter
Planeshifter approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Jul 28, 2024
@Planeshifter Planeshifter merged commit f5d15f7 into stdlib-js:develop Jul 28, 2024
8 checks passed
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
feat: add C implementation for math/base/special/sincospi
e49ed78 
PR-URL: stdlib-js#2687 
Ref: stdlib-js#649 

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @Planeshifter @stdlib-bot