refactor: use max-safe-nth-factorial package in math/base/special/factorial
#2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2676 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
max-safe-nth-factorialpackage instead of explicitly declaring a variable inmath/base/special/factorial.Related Issues
None.
Questions
No.
Other
I've used the full name, i.e.,
FLOAT64_MAX_SAFE_NTH_FACTORIALinstead ofMAX_FACTORIAL, in thejavascriptimplementation as well.Checklist
@stdlib-js/reviewers