Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/sincos #2646

Merged
merged 5 commits into from
Jul 26, 2024
Merged

feat: add C implementation for math/base/special/sincos #2646

merged 5 commits into from
Jul 26, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 22, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

void stdlib_base_sincos( const double x, double* sine, double* cosine );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 22, 2024
Planeshifter
Planeshifter approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jul 26, 2024
@Planeshifter Planeshifter merged commit 2c377eb into stdlib-js:develop Jul 26, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the sincos branch July 27, 2024 03:24
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
feat: add C implementation for math/base/special/sincos
241885d 
PR-URL: stdlib-js#2646
Ref: stdlib-js#649 

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunjjoshi @Planeshifter @kgryte @stdlib-bot