feat: add C implementation for math/base/special/cos
#2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
@gunjjoshi Thank you, @gunjjoshi! Will merge shortly. |
Planeshifter
approved these changes
Jun 10, 2024
kgryte
reviewed
Jun 10, 2024
| #ifndef STDLIB_MATH_BASE_SPECIAL_COS_H | ||
| #define STDLIB_MATH_BASE_SPECIAL_COS_H | ||
|
|
||
| #include <stdint.h> |
| #include <stdint.h> | ||
|
|
||
| // High word absolute value mask: 0x7fffffff => 01111111111111111111111111111111 | ||
| static const int32_t HIGH_WORD_ABS_MASK = 0x7fffffff; |
There was a problem hiding this comment.
I believe we have a constant package for this.
| static const int32_t HIGH_WORD_TWO_NEG_27 = 0x3e400000; | ||
|
|
||
| // High word exponent mask: 0x7ff00000 => 01111111111100000000000000000000 | ||
| static const int32_t HIGH_WORD_EXPONENT_MASK = 0x7ff00000; |
There was a problem hiding this comment.
Same comment. We have a pkg for this, IIRC.
1 task
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 11, 2024
PR-URL: stdlib-js#2352 Ref: stdlib-js#649 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 11, 2024
PR-URL: stdlib-js#2355 Ref: stdlib-js#2352 Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2352 Ref: stdlib-js#649 --------- Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2355 Ref: stdlib-js#2352 Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/cos.Related Issues
This pull request:
Questions
No.
Other
I have added the extended comment from the
FreeBSDsource in both theCandjavascriptimplementations.Checklist
@stdlib-js/reviewers