Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/asecf #2120

Merged
merged 3 commits into from
Apr 5, 2024
Merged

feat: add math/base/special/asecf #2120

merged 3 commits into from
Apr 5, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 4, 2024 •
edited
Loading

Resolves #2118 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Test coverage report:
Screenshot 2024-04-04 at 23 03 19

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 4, 2024
@gunjjoshi
Copy link
Member Author

While working on this, I found that in asec, we might have incorrectly added "hyperbolic" in package.json.

Should I remove that too, in a quick patch ?

@kgryte
Copy link
Member

kgryte commented Apr 4, 2024

@gunjjoshi Yes, go for it! Thanks!

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 4, 2024
@kgryte
Apply suggestions from code review
8689fb8 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gunjjoshi, for working on this. My main comment concerns test fixture generation. Once resolved, this should be good to merge.

@kgryte
Copy link
Member

kgryte commented Apr 5, 2024

@gunjjoshi Did the test fixtures remain the same? I am guessing yes since you did not add them in the commit.

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Apr 5, 2024 •
edited
Loading

@kgryte Yes, they did remain the same. To re-check, I even deleted all the fixtures, re-generated them, still they didn't had any changes with the previous ones, and so they didn't come up in the commit.

@kgryte
Copy link
Member

kgryte commented Apr 5, 2024

@gunjjoshi Thanks for the following up. In which case, I think this PR is good to go.

@kgryte kgryte merged commit 675ca1f into stdlib-js:develop Apr 5, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the asecf branch April 5, 2024 05:08
@gunjjoshi gunjjoshi mentioned this pull request Apr 5, 2024
Merged
1 task
kgryte pushed a commit that referenced this pull request Apr 5, 2024
@gunjjoshi
test: fix test fixture generation and update meta data
9c493c0 
PR-URL: 	#2123
Ref: #2120 (comment)
Ref: #2120 (comment)
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add math/base/special/asecf
3 participants
@gunjjoshi @kgryte @stdlib-bot