Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/atanf #2054

Merged
merged 14 commits into from
Mar 27, 2024
Merged

feat: add math/base/special/atanf #2054

merged 14 commits into from
Mar 27, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 26, 2024 •
edited
Loading

Resolves #2035 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 26, 2024
@gunjjoshi
Copy link
Member Author

Code coverage report:

Screenshot 2024-03-26 at 22 45 27

@gunjjoshi
Delete lib/node_modules/@stdlib/math/base/special/asinf/lib/main.js
2deeb8c 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Delete lib/node_modules/@stdlib/math/base/special/atanf/lib/main.js
6b1c2b2 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
feat: add math/base/special/atanf
22e7b0a
@gunjjoshi
feat: add math/base/special/atanf
1f2df1f
@gunjjoshi
Update main.js
f42dced 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update main.c
a0ce3b5 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Copy link
Member Author

This is ready for review now.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 26, 2024
@kgryte
Apply suggestions from code review
dc912bd 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
9cfe81e 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
75eb40f 
Signed-off-by: Athan <kgryte@gmail.com>
@gunjjoshi
Update README.md
b1a91f7 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update test.js
64a15c0 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update test.native.js
defda1f 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Copy link
Member Author

Thanks for the suggestions @kgryte. I have incorporated the changes.

kgryte
kgryte approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit f141a9b into stdlib-js:develop Mar 27, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the atanf branch March 27, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add math/base/special/atanf
3 participants
@gunjjoshi @kgryte @stdlib-bot