Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/gamma-lanczos-sum-expg-scaled #1980

Merged
merged 4 commits into from
Mar 24, 2024
Merged

feat: add C implementation for math/base/special/gamma-lanczos-sum-expg-scaled #1980

merged 4 commits into from
Mar 24, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 21, 2024 •
edited
Loading

Resolves #1835.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 21, 2024
@gunjjoshi
Update benchmark.native.js
729c1c7 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update native.js
202b2df 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 23, 2024
Planeshifter
Planeshifter approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @gunjjoshi!

@gunjjoshi @Planeshifter
Update lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum-e…
c25131e 
…xpg-scaled/lib/rational_pq.js

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter merged commit e8f94d2 into stdlib-js:develop Mar 24, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the gamma-lanczos-sum-expg-scaled branch March 24, 2024 02:13
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 24, 2024
kgryte added a commit that referenced this pull request Mar 24, 2024
@kgryte
docs: fix descriptions
b6968e0 
Ref: #1980
Ref: e8f94d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/special/gamma-lanczos-sum-expg-scaled
4 participants
@gunjjoshi @Planeshifter @kgryte @stdlib-bot