Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected include directory name for constants/float32/half-pi #1976

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: corrected include directory name for constants/float32/half-pi #1976

merged 1 commit into from
Mar 21, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • renames the include directory name for constants/float32/half-pi

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 21, 2024

Sorry for the mistake, the folder had named as float64 instead of float32. I'd be more cautious from now onwards.
This PR is a pre-requisite for #1950.

cc: @kgryte

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching!

@kgryte kgryte merged commit 2bf94d2 into stdlib-js:develop Mar 21, 2024
6 checks passed
@gunjjoshi gunjjoshi deleted the half-pi-float32 branch March 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants