Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/bernoulli #1860

Merged
merged 7 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/special/bernoulli #1860

merged 7 commits into from
Mar 14, 2024

Conversation

gunjjoshi
Copy link
Member

Resolves #1664

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@gunjjoshi
Copy link
Member Author

Since there was inactivity on #1664 due to a dependency's C implementation not being done, and all its dependencies' C installation are done now, so I've made this PR.

@Pranavchiku
chore: apply suggestions from code review
36c012f 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, once done this will be ready to merge.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 13, 2024
gunjjoshi and others added 3 commits March 13, 2024 23:30
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
84525ad 
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/bernoulli/src/main.c
9048821 
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update main.c
42eafff 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 13, 2024 •
edited
Loading

I have made the changes as per your suggestions. Thanks for pointing them out @Pranavchiku !

@Pranavchiku
chore: apply suggestions from code review
c007089 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally. Looks good to me. Thanks @gunjjoshi !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 13, 2024
@Planeshifter Planeshifter merged commit 0c78f2f into stdlib-js:develop Mar 14, 2024
7 checks passed
@gunjjoshi gunjjoshi deleted the bernoulli branch March 14, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/bernoulli
3 participants
@gunjjoshi @Pranavchiku @Planeshifter