Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/negafibonacci #1813

Merged
merged 19 commits into from
May 29, 2024
Merged

feat: add C implementation for math/base/special/negafibonacci #1813

merged 19 commits into from
May 29, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 10, 2024 •
edited
Loading

Resolves #1758

Description

This PR adds the C implementation of @stdlib/math/base/special/negafibonacci.

What is the purpose of this pull request?

This pull request:

  • adds the C implementation of @stdlib/math/base/special/negafibonacci.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

In the implementation of negafibonacci, I have used the same constant as that in @stdlib/math/base/special/fibonacci, i.e., stdlib/constants/float64/max_safe_nth_fibonacci.h, as both fibonacci and negafibonacci exist till the same constant, i.e., 78.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Pranavchiku
Pranavchiku requested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, thanks for your work @gunjjoshi !

lib/node_modules/@stdlib/math/base/special/negafibonacci/benchmark/benchmark.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/negafibonacci/benchmark/benchmark.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/negafibonacci/lib/native.js Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/negafibonacci/src/main.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/negafibonacci/src/main.c Show resolved Hide resolved
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 10, 2024
gunjjoshi and others added 7 commits March 10, 2024 18:37
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/negafibonacci/bench…
d0ac8e6 
…mark/benchmark.native.js

Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/negafibonacci/lib/n…
eb59bfb 
…ative.js

Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/math/base/special/negafibonacci/src/m…
ae06008 
…ain.c

Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update benchmark.native.js
aaa3a7b 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update benchmark.native.js
127096d 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update benchmark.native.js
b608dd7 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
Update README.md
cc9f3c1 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/negafibonacci feat: add C implementation for math/base/special/negafibonacci Mar 11, 2024
@Pranavchiku
chore: apply suggestions from code review
de876f3 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply code review
3e33a99 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
ec4346b 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
fix: incorrect implementation
3aac70a 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
5385822 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gunjjoshi !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 13, 2024
@kgryte kgryte removed the Ready To Merge A pull request which is ready to be merged. label Mar 14, 2024
@kgryte kgryte self-requested a review March 14, 2024 11:14
@gunjjoshi
Update addon.c
6ded515 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
gunjjoshi and others added 4 commits May 29, 2024 08:34
@gunjjoshi
remove unnecessary checks as n is already int32_t
b4d65e3 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
corrected example
5d73cef 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi
check to return NaN, not 7
eebfd49 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
@gunjjoshi @Planeshifter
Update lib/node_modules/@stdlib/math/base/special/negafibonacci/src/m…
17dbeb2 
…ain.c

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Planeshifter
Planeshifter approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's get this in!

@Planeshifter Planeshifter merged commit 1bc3682 into stdlib-js:develop May 29, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the negafibonacci branch June 11, 2024 03:12
aman-095 pushed a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
@gunjjoshi @Pranavchiku
@Planeshifter @aman-095
feat: add C implementation for math/base/special/negafibonacci
1a4dffc 
PR-URL: stdlib-js#1813
Closes: stdlib-js#1758 
Ref: stdlib-js#649

---------

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in>
Co-authored-by: Pranav Goswami <goswami.4@iitj.ac.in>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> 
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/negafibonacci
4 participants
@gunjjoshi @Planeshifter @kgryte @Pranavchiku