Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add C implementation for math/base/special/binomcoef #2206

Closed
3 tasks done
gunjjoshi opened this issue Apr 26, 2024 · 1 comment · Fixed by #2729
Closed
3 tasks done

[RFC]: add C implementation for math/base/special/binomcoef #2206

gunjjoshi opened this issue Apr 26, 2024 · 1 comment · Fixed by #2729
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Member

Description

This RFC proposes adding C implementation for math/base/special/binomcoef.

double stdlib_base_binomcoef( const double n, const double k );

Related Issues

Related issues #649.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

I'd like to work on this.

@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. C Issue involves or relates to C. labels Apr 27, 2024
@gunjjoshi gunjjoshi mentioned this issue Aug 1, 2024
Merged
1 task
kgryte added a commit that referenced this issue Aug 1, 2024
@gunjjoshi @kgryte
feat: add LL_D in math/base/napi/binary
46cda32 
PR-URL: #2726
Ref: #2206
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
@gunjjoshi gunjjoshi mentioned this issue Aug 2, 2024
Merged
1 task
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Aug 21, 2024
@gunjjoshi @kgryte
feat: add LL_D in math/base/napi/binary
3c8c786 
PR-URL: stdlib-js#2726
Ref: stdlib-js#2206
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/binomcoef gunjjoshi/stdlib
2 participants
@kgryte @gunjjoshi