-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got "Connecting to peers" or "Offline" and couldn't send new messages after going back from sleep mode #6396
Comments
@goranjovic Did you have this issue on Linux too? |
@chadyj No, but I do constantly have it on Mac |
Can be reproducible on mobile as well, only restarting app helps (faced with this on IOS and on Android 7.0 (Genymotion emulator, Samsung Galaxy S7)) |
Also two hackaton participants mentioned that they had this problem on genymotion run within osx. Restarting the app helped. |
See: #6284 (comment) for more info |
@churik can you still replicate? I can't replicate on my local machine or android. If you do, it would be helpful to get the So far what I have:
A potential band-aid would be to poll net-info periodically, but that would only help if we were not notified, but the internal state is otherwise ok (i.e react-native knows that is online, but for whatever reason the event was not fired/ the listener was not attached correctly). Other people seems to have similar issues facebook/react-native#8615 , and some rolled out their own connection checks, which is a solution, although heavy-handed. If anyone can replicate, please send logs!
|
@cammellos yes, I can still reproduce it (Mac OSx, go offline ~5 min, go back online. Reproducibility ~20%)
Within #6865 I can see that app is actually connected to 3 peers but Offline is still shown (Video: http://take.ms/GRopV) |
@cammellos Would be great if you can grab this to get it included in the 0.9.0 desktop release next week (if you still have context and bandwidth) |
@cammellos Planned on working on #6961 this week, but not started yet. So please take over :) |
@cammellos I know you have your plate full but we are hoping to include this in the desktop release next week. |
@chadyj PR is out #7012 should fix the offline problem + add cconfirmations from the mailserver , is ready to be tested, but depends on #6877. Confirmations are not enabled by default in release (only in nightlies/dev) as if mailservers are down or unreachable the user will see their messages as not-sent (they will be sent though), but in most cases will provide better guarantees of delivery. |
@annadanchenko, can we close this now, when #7012 merged? |
It can be closed, yes |
Description
Type: Bug
Summary: can reproduce it constantly on Mac OSx VM 10.13.6, but cannot find exact action on the local computer.
When VM came back from sleep mode, app doesn't detect online mode and all messages, sent from this state will be never received.
Expected behavior
can send\receive messages
Actual behavior
"Connecting to peers", messages are displayed as sent, but they are not sent.
Reproduction
NOTE: issue is gone after app restarting
Additional Information
Logs
https://drive.google.com/open?id=1R9nhxD83qYycpUYNeUHdnYJR57WU4HLy
The text was updated successfully, but these errors were encountered: