Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status desktop appears "offline" when online #6284

Closed
J12B opened this issue Oct 12, 2018 · 10 comments
Closed

Status desktop appears "offline" when online #6284

J12B opened this issue Oct 12, 2018 · 10 comments
Assignees

Comments

@J12B
Copy link

J12B commented Oct 12, 2018

comment: # Status desktop shows as "offline" even when online.

User Story

Desktop on Mac. Had a brief connection problem on my mac and went offline. As expected, the Status app showed "offline". When i came back online (as confirmed by receiving messages through status and using a web browser), the status app still shows "offline." I've been online for 10 minutes now, but the app still shows offline.

Description

comment: # Bug
Type: Bug

Expected behavior

comment: # The "offline" header should disappear when I'm online.

Actual behavior

comment: # The "offline" header remained even when I'm online.

Additional Information

  • Status version: V0.0.1 (02cb5dc)
    comment: # Mac
  • Operating System: Mac OS High Sierra 10.13.6

Logs

...
@J12B J12B added bug labels Oct 12, 2018
@rasom rasom assigned rasom and unassigned rasom Oct 15, 2018
@dshulyak
Copy link
Contributor

I can reproduce this issue. Definitely see that i established connections with peers after application was resumed. But desktop app always shows "offline" message. I think same problem appears on IOs when app moved from background.

@yenda @cammellos when do remove "offline" warning? is it when "discovery.summary" returns peers or there is additional logic? there is definitely a bug, either in handling that event or in status-go module.

@dshulyak
Copy link
Contributor

dshulyak commented Nov 14, 2018

I can reliably reproduce this situation.
Steps:

  1. run desktop app
  2. simulate network conditions. turn off your wifi, disable interface, or use this tool https://github.com/tylertreat/comcast
  3. ensure that all establishrf connections with app disappeared. lsof -i -P <status pid>
  4. see in the logs that discovery.summary is empty:
17:16:14.543 - D - [RCTStatus] - ::onStatusGoEvent call - event:  {"type":"discovery.summary","event":[]}
  1. enable network, wait for established connections
  2. see in log that discovery.summary was restored
17:17:00.262 - D - [jsserver] - [status-im.events:685] - :event-str {"type":"discovery.summary","event":[{"id":"c42f368a23fa98ee546fd247220759062323249ef657d26d357a777443aec04db1b29a3a22ef3e7c548e18493ddaf51a31b0aed6079bd6ebe5ae838fcfaf3a49","name":"Statusd/v0.16.4/linux-amd64/go1.10.2","caps":["shh/6"],"network":{"localAddress":"192.168.0.107:34888","remoteAddress":"206.189.243.162:30504","inbound":false,"trusted":false,"static":true},"protocols":{"shh":"unknown"}},{"id":"f34451823b173dc5f2ac0eec1668fdb13dba9452b174249a7e0272d6dce16fb811a01e623300d1b7a67c240ae052a462bff3f60e4a05e4c4bd23cc27dea57051","name":"Statusd/v0.16.4/linux-amd64/go1.10.2","caps":["shh/6"],"network":{"localAddress":"192.168.0.107:36918","remoteAddress":"47.52.173.66:30305","inbound":false,"trusted":false,"static":true},"protocols":{"shh":"unknown"}}]}
GitHub
Simulating shitty network connections so you can build better systems. - tylertreat/comcast

@cammellos
Copy link
Contributor

cammellos commented Nov 14, 2018 via email

@yenda yenda self-assigned this Nov 14, 2018
@dshulyak
Copy link
Contributor

@cammellos i am using builds from tuesday and monday. can reproduce on both of them. should i try to reproduce on latest build?

@cammellos
Copy link
Contributor

cammellos commented Nov 14, 2018 via email

@churik
Copy link
Member

churik commented Nov 14, 2018

@cammellos duplicate? #6396

@cammellos
Copy link
Contributor

seems like, feel free to close one, I will assign both to me, thanks for spotting it

@cammellos
Copy link
Contributor

@dshulyak I can't replicate myself, everything works as expected, would it be possible to get all the logs from just before you go offline till you are back online ~/.local/share/Status/Status.log if you are running an actual build or the output of node ubuntu-server.js if you are actually running the development stack.

Also, when it displays offline but you are online (error condition), if you go to any chat, and write a message, is the send button visible/enabled?

@dshulyak
Copy link
Contributor

dshulyak commented Nov 15, 2018

I am trying to reproduce it again to get logs but i can't. Not sure why. Button to send a message was blocked, but i was receiving new messages.

It is probably not related to discovery.summary. Now warning switches to "connecting to peers". and gets removed once i have at least one peer in discovery.summary.

@dshulyak
Copy link
Contributor

dshulyak commented Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants