Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yamux experimental support #5080

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Add Yamux experimental support #5080

merged 3 commits into from
Jun 23, 2023

Conversation

Menduist
Copy link
Contributor

@Menduist Menduist commented Jun 15, 2023

Mplex is starting to get slowly kicked out of libp2p, and it's probably for the best

We've had experimental yamux in nim-libp2p for a while, but it had limited testing on actual networks
Adding this flag, so that we can test on a few fleet nodes, and in some future, make it default to true

Also see libp2p/specs#553

@tersec
Copy link
Contributor

tersec commented Jun 15, 2023

Maybe mark this hidden, and/or otherwise signal that it's not a supported option?

This seems ideally ephemeral/temporary and to be removed at some point.

@Menduist
Copy link
Contributor Author

Thanks, I wasn't aware that this was possible

@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 071 suites  ±0   33m 53s ⏱️ - 4m 52s
  3 698 tests  - 1    3 419 ✔️  - 1  279 💤 ±0  0 ±0 
15 760 runs   - 3  15 455 ✔️  - 3  305 💤 ±0  0 ±0 

Results for commit b3a5ff3. ± Comparison against base commit 939b300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants