Fix source-selector being blocked on mobile
#5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small CSS change to allow the `source-selector` to be brought to the front of the controls to allow people to select which source they would like. At first, I was going more complex. I created functions that would disable the `big-buttons` if a menu was open and I got it mostly working but I felt like it was overkill when we can modify like 3-4 lines of CSS and get the same result. fixes stashapp#4066
|
Could you change the title of the pull request? Small CSS changes doesn't tell anything about the actual change. Worst case is that the version history would be full of "Small CSS changes" commits and the reader would have to check every commit manually to find the correct one. |
|
For example "Allow |
DogmaDragon
changed the title
source-selector being blocked on mobile
|
Thanks, DD :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small CSS change to allow the
source-selectorto be brought to the front of the controls to allow people to select which source they would like. Added it into the section for mobile changes ( < 576px) as it's not really needed on anything bigger but can move it if told otherwiseAt first, I was going more complex. I created functions that would disable the
big-buttonsif a menu was open and I got it mostly working but I felt like it was overkill when we can modify like 3-4 lines of CSS and get the same result.fixes #4066