Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make image extension check in zip files case insensitive #501

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Make image extension check in zip files case insensitive #501

merged 3 commits into from
Apr 28, 2020

Conversation

bnkai
Copy link
Collaborator

@bnkai bnkai commented Apr 25, 2020

Also add webp as a supported extension for the galleries

@bnkai bnkai added the improvement Something needed tweaking. label Apr 25, 2020
@bnkai bnkai added this to the Version 0.2.0 milestone Apr 25, 2020
WithoutPants
WithoutPants requested changes Apr 26, 2020
View reviewed changes
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think contains should just do a case-insensitive match instead of matching lowercase

pkg/models/model_gallery.go Outdated Show resolved Hide resolved
pkg/models/model_gallery.go Outdated Show resolved Hide resolved
@WithoutPants WithoutPants merged commit 52a1059 into stashapp:develop Apr 28, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@bnkai
Make image extension check in zip files case insensitive (stashapp#501)
b706a89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WithoutPants WithoutPants WithoutPants approved these changes

Assignees
No one assigned
Labels
improvement Something needed tweaking.
Projects
None yet
Milestone
Version 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bnkai @WithoutPants