Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean missing galleries #489

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Clean missing galleries #489

merged 3 commits into from
Apr 24, 2020

Conversation

WithoutPants
Copy link
Collaborator

Changed the clean operation so that it also checks and removes galleries that are no longer present. Changed the clean dialog message accordingly.

@WithoutPants WithoutPants added the bug Something isn't working label Apr 22, 2020
@WithoutPants WithoutPants added this to the Version 0.2.0 milestone Apr 22, 2020
bnkai
bnkai reviewed Apr 22, 2020
View reviewed changes
pkg/manager/manager_tasks.go Outdated Show resolved Hide resolved
@bnkai
Copy link
Collaborator

bnkai commented Apr 22, 2020

Not related to your changes
Can you replace in pkg/manager/exclude_files.go function matchFile
logger.Infof("No exclude patterns in config.")
with
return false ?
I noticed that it pollutes the log if no exclude pattern is set in the config.

Everything tests out ok

@WithoutPants WithoutPants merged commit 5923917 into stashapp:develop Apr 24, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@WithoutPants
Clean missing galleries (stashapp#489)
a2740f6 
* Clean missing galleries
* Refactor matchFile
@WithoutPants WithoutPants deleted the clean-gallery branch February 4, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnkai bnkai bnkai left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WithoutPants @bnkai