Tag Favoriting

[Dankonite]

added tag favoriting, still needs the filter support

[Dankonite]

Added the filter getting a wierd error tho and no idea what causes this. Not ready yet

[Dankonite]

Finally got the filter to work

[WithoutPants]

Thanks for the PR. Please address the failed checks.

[Dankonite]

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

[SpedNSFW]

sorry, new to linters and such, no idea if that was the only problem or if I need to clean up something else also. I will google a proper linting tutorial if more stuff comes back messy

Just look through your changes and undo the pointless ones, like changing indentation. That would be a start. For the others, go to checks and look at the details for why they're failing.

[Dankonite]

so I ran yarn validate and some of the stuff that is throwing errors are things I didnt even mess with lmao

Do I need to make these changes from a diferent branch or something. I just forked off of develop maybe at a bad time or something

[DogmaDragon]

Migration version conflicts with existing one https://github.com/stashapp/stash/blob/develop/pkg/sqlite/migrations/56_studio_favorite.up.sql.

You will need to either update the existing migration or bump the version.