-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slim endpoints for entities to speed up filters #460
Add slim endpoints for entities to speed up filters #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm 7x-8x speedup also for the performers and studios part
(536 Performers 627 Studios in my db)
Testing against a database with 1,968 performers, I'm not seeing any difference before and after this change. I'm seeing between 7.5 and 12 seconds for |
@WithoutPants Try now. I've added a migration that moves the |
I was getting consistent speedup in the edit scene tab as stated above also. @WithoutPants is your db maybe in a spinning disk? ( my tests were in sata ssd and nvme ssd) |
With latest commit : Time for AllPerformers |
I'm getting consistent times of around 50ms for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should take the opportunity to remove the redundant index.
* Move performers image column to end of table * Remove redundant index
Should resolve issue #452
In my library with 123 performers and 1MB-ish performer images it speeds up AllPerformersForFilters from 0.4s to 0.04s. For 549 studios it speeds up from 0.08s to 0.02s.
I considered changing the dropdowns to fetch on demand, but considering that scenes can have arbitrary amount of performers attached, it would likely make page load significantly slower in many instances.