Add scene rating to scene filename parser #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works ok. |
|
Fixed v2.5 so that it is possible to unset rating. Fixed parser results refreshing twice after applying changes. Fixed rating selection not being correctly disabled when checkbox was unchecked. Also includes a change to ignore line endings in the scss files so that the formatter works properly on Windows. |
|
It seems to work ok now. Can confirm that double loading is gone and setting, unsetting are fine also. |
Anon247
pushed a commit
to Anon247/stash
that referenced
this pull request
Apr 11, 2020
* Fix scene parser display issues in 2.5 * Dropdown menu presentation improvements * Fix refresh on parser apply * Ignore line endings on scss files
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Fix scene parser display issues in 2.5 * Dropdown menu presentation improvements * Fix refresh on parser apply * Ignore line endings on scss files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
Adds
{rating}as a parsable field to the scene filename parser. Added to v2 and v2.5 of the UI.Also fixes up display issues in the v2.5 version of the scene filename parser page.