Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ethnicity freetext and fix freeones ethnicity panic #431

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

WithoutPants
Copy link
Collaborator

Fixes #367

Makes ethnicity free-text in v2 and v2.5 UI. Changed freeones scraper to return original string if an unknown ethnicity is encountered.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 1, 2020
@WithoutPants WithoutPants added this to the Version 0.2.0 milestone Apr 1, 2020
Copy link
Collaborator

@bnkai bnkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work ok as described both the freetext change and the freeones scraper.
Tested v2 , v2.5

@WithoutPants WithoutPants merged commit 82201e2 into stashapp:develop Apr 1, 2020
Anon247 pushed a commit to Anon247/stash that referenced this pull request Apr 11, 2020
* Make ethnicity free text

* Fix panic in freeones scraper for other ethnicity
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Make ethnicity free text

* Fix panic in freeones scraper for other ethnicity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] 'Unknown Ethnicity' Error When Scraping for Performer Info
2 participants