Add library size to main stats page #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Mar 28, 2020
pkg/models/querybuilder_scene.go
Outdated
| func (qb *SceneQueryBuilder) SizeCount() (string, error) { | ||
| sum, err := runSumQuery("SELECT SUM(size) as sum FROM scenes", nil) | ||
| if err != nil { | ||
| return "O", err |
There was a problem hiding this comment.
Out of curiosity, what's the purpose of returning O? Can you not return an empty string?
There was a problem hiding this comment.
"0" seemed better than an empty string since we are talking about size. But doesn't actually matter , do you think "" would look better?
There was a problem hiding this comment.
I don't really have a preference since it's an error anyway, I was just curious since it returns the letter O. 0 makes more sense.
There was a problem hiding this comment.
oh it was supposed to be "0" (zero) ! Just noticed that now , typo...
WithoutPants
approved these changes
Apr 3, 2020
Anon247
pushed a commit
to Anon247/stash
that referenced
this pull request
Apr 11, 2020
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the library size ( sum of the sizes of all scenes ) to the stats page.
closes #426