Add modes for performer/tag for bulk scene editing #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok , tests ok. |
|
Given that add/remove operations are iterative, I made the design decision to only show the common tags/performers when in Set mode. I think it would be unhelpful to fill in these values in the other modes, but I'm not convinced that my implementation is the most intuitive either, so I am open to suggestion. |
|
Just wasn't sure what to expect, it works for me. Might be better to merge it as is and get feedback from more users. |
bnkai
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #250
Adds a button to the performer and tag controls in the bulk scene update UI. This button shows the current mode of the operation - Add, Remove and Set. The set mode overwrites the existing ids with the ids supplied. Add and Remove are iterative operations using existing data.
Added to version 2 and 2.5 UI.