Performer select refactor #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2024
Merged
Merged
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Overhaul performer select * Add interface to load performers by id * Add Performer ID select and replace existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to removing the select controls which load entire datasets into the client (performers, studios and tags). This addresses the performer select specifically.
The new select control no longer uses
allPerformers(and this interface has been marked as deprecated). The main select control now stores performer objects instead of ids. For ease of compatibility, aPerformerIDSelectcontrol is added where it's not easy to use objects. This control will load performers by id as needed, and a modification tofindPerformerswas made to accept a list of performer ids.The presentation of the performer results is tweaked to show the actual matching performer alias (instead of a hardcoded
(alias)string), and it only shows this if the search string matches an alias.(
has foois an alias ofhas bar).I expect this to improve performance for users with a significant amount of performers in their database.
This change will be adapted to tags, studios and movies in future so that the
all[objects]interfaces are no longer used.