Change modifier selector to pills #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the area becomes too large, we can use half margin half padding. Reduces the amount of pixel hunting required to click.
WithoutPants
added
improvement
bnkai
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the existing modifier selector dropdown with a set of clickable pills. This reduces a click and looks decent imo.
Also increases the clickable area of the
xremove button in the criterion pills. The clickable area now starts where the text ends, instead of the edge of thexicon. This fixes a UX frustration that I've encountered where trying to click thexopens the criteria editor instead. Should reduce the amount of pixel hunting required to click it. If the clickable area is too large, I can adjust it to halfway between the text and thex.