Log errors returned from graphql #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added logging for when the user logs in or out, when invalid credentials are entered, and when credentials are changed. |
bnkai
reviewed
Mar 22, 2023
| @@ -34,7 +34,15 @@ const ( | |||
| passwordFormKey = "password" | |||
| ) | |||
|
|
|||
| var ErrInvalidCredentials = errors.New("invalid username or password") | |||
| type InvalidCredentialsError struct { | |||
| Username string | |||
There was a problem hiding this comment.
Is this actually used anywhere? I only see it set when initializing ?
Wouldnt an empty struct be enough?
There was a problem hiding this comment.
I originally had this field included in the Error method, but I've taken it out for now (until we support multiple users). Having the field means that we can read the username from the calling code, so it's useful, just not currently in use.
bnkai
reviewed
Mar 22, 2023
bnkai
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an error presenter to the graphql interface that logs any encountered errors to the error log level. Also logs the request arguments at the debug log level when an error is encountered.