Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show sprite button to scene tagger list #3536

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

Flashy78
Copy link
Contributor

Resolves #3534

Adds an image icon to each scene in the tagger view that displays the sprite file in a lightbox. The icon doesn't not show up if there is no file for the scene.

Suggestions on a better UI than shown in #3534 are welcome.

@DogmaDragon DogmaDragon added the improvement Something needed tweaking. label Mar 13, 2023
@WithoutPants
Copy link
Collaborator

The alternative I think would be similar to the duplicate scene checker tool. I'd move the icon to be overlapping the bottom right corner of the thumbnail, and have the sprite image show on hover. Showing the sprite image in a lightbox seems like too much to me, but I'm not totally against it.

@DogmaDragon
Copy link
Collaborator

DogmaDragon commented Mar 13, 2023

The alternative I think would be similar to the duplicate scene checker tool. I'd move the icon to be overlapping the bottom right corner of the thumbnail, and have the sprite image show on hover.

Something like this would be my preference. Maybe it's just me not being used to lightbox or me being used to how the dupe checker displays it.

@Flashy78
Copy link
Contributor Author

I moved the icon to overlap the top left of the thumbnail, it was much easier than caclulating where it needs to be if the thumbnail is portrait or landscape, and also because there can often be a useful watermark in the bottom right that is nice not to cover when tagging.

I found being able to zoom into the image very useful sometimes, so the lightbox worked best for me.
I also didn't want to be instrusive to existing users by having something randomly popping up and taking over their screen as they moved their mouse around.

@WithoutPants WithoutPants added this to the Version 0.20.0 milestone Mar 14, 2023
@WithoutPants WithoutPants merged commit e2b52a4 into stashapp:develop Mar 14, 2023
@Flashy78 Flashy78 deleted the tagger-sprite branch April 11, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] View sprites in scene tagger
3 participants