-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated - feat: UI - Performer scraper result list with image and basic data #3499
Updated - feat: UI - Performer scraper result list with image and basic data #3499
Conversation
fix: Images works in YAML scrapers too (cast string to []string)
fix: uses postScrape in ScrapeName (Scrape with name/query)
Results way faster search result if they include images needed to convert url to base64
Latest 3 commits fixup the eslint issues I had |
Getting all images and encoding them as base64 is the wrong approach in my opinion. The stash-box implementation returns the URLs to the images only. We should probably return the direct URLs, and they should be loaded only as needed by the UI. I think that this PR should be split up so that we can solve these issues separately:
I won't close this PR yet, but I won't be merging it with the current design. |
Thanks for the review. I can work with that :) |
I'm not sure but as far as i remember, i have once again talked or wrote regarding this somewhere, maybe in the code comments! That's the right approach in my opinion! Requesting data with one Device/IP and other things such as assets from another Device/IP can simply leak IP and/or other things, it may not even be what the user really want. |
Good point. I kind of touched the surface of that with the referrer stuff. I think the solution is as follows:
|
This is the same as #2697, updated for the codebase as it sits currently and improved upon slightly. I'd definitely appreciate a code review on this, it's been a few years since I've messed around with React.
From the original PR:
UI Changes
To the performer scraper query modal:
To the performer scraper confirmation modal: