Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Responsive UI changes #243

Closed
wants to merge 17 commits into from

Conversation

WithoutPants
Copy link
Collaborator

This is an extension of the #232 branch. I've looked at doing a larger overhaul to try to make the stash UI more small-screen-friendly.

Specific changes here are to convert the filter bar into a navbar with left and right aligned elements, add a small-device specific menu of the top navbar items, change first/last/previous/next pagination buttons to use icons instead, and use a smaller number of pages on smaller devices.

This may possibly replace #232 if we're happy with the additions, or I can attempt to split everything up.

@WithoutPants
Copy link
Collaborator Author

Screenshots. This is what the scene filter and navbar looks like on a larger device:

image

Note that the select all/none, zoom slider and view button have been moved to the right, with the rest moved to the left - rather than all in the centre. On larger screens, the left contents are to the left of the first scene card. I don't know whether this bothers people:

image

This is what it looks like on a phone:

image

The overflow of the filter controls is not ideal, and nor is the truncating of the page size, but not a dealbreaker and is something I can look at later. Notice that the navbar page links have been replaced with a menu button. Here is what the menu looks like when opened:

image

This is what the pagination looks like on a small device:

image

Notice the chevrons instead of First/Last/Previous/Next. These are on the larger version as well, only the number of pages displayed changes.

There are plenty of pages that still don't work well on a small device. These include:

  • list views, including the tags page
  • performer page seems to lose the settings button
  • settings page

@Leopere
Copy link
Collaborator

Leopere commented Dec 5, 2019

It looks like #232 progressed faster than this and got merged. A responsive UI would be an incredible value add, in my opinion.

@WithoutPants
Copy link
Collaborator Author

I'm going to close this for now, in preference for breaking it up into smaller, separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants