-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload pull request builds to transfer.sh #165
Conversation
64d229e
to
0f9067c
Compare
Build ran for 13 minutes, 12 seconds. Average build prior to this change is around 8 minutes. Looks like most of the extra time is spent performing the cross compile. Upload is only taking around 15 seconds.
|
It's not ideal uploading for every build but the reason I suggested Transfer.sh is that it disposes of the files after 30 days so we're not cyber littering. |
One of the things we should do is add a |
The idea here would be to allow someone with a local copy of the repository to be able to test their PR's that are tested on TravisCI locally within Docker or whatever they use. |
It seems useful for user beta testing and the files get deleted anyway , i would say it doesn't hurt to have it... |
now we just need to resolve the travis.yml issue and then I will merge it. |
0f9067c
to
2d693e3
Compare
Adds a script to upload the binaries built from a pull request to transfer.sh. The URL is output in the build log. By submitting this pull request, I'm hoping that it will test successfully.
I'm not sold on the idea of uploading three large binaries for every build of every pull request, but this (hopefully) shows that it can be done.
Related to #139