Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wait #661 merge] Eradicate static strings v2 #662

Merged
merged 5 commits into from
Jun 29, 2023
Merged

[Wait #661 merge] Eradicate static strings v2 #662

merged 5 commits into from
Jun 29, 2023

Conversation

tabaktoni
Copy link
Collaborator

@tabaktoni tabaktoni commented Jun 28, 2023 •
edited
Loading

Branched from #661

Motivation and Resolution

  • Remove static string usage for types (v2 clean over, 14th pass Fix types #540)
  • extract Cairo types

Development related changes

Use Types instead of static string's

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 47de466
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/649d3cc1f8e7430008d550d0

@tabaktoni tabaktoni changed the title Eradicate static strings v2 [Wait #661 merge] Eradicate static strings v2 Jun 28, 2023
@penovicp penovicp mentioned this pull request Jun 29, 2023
Merged
6 tasks
@tabaktoni tabaktoni requested a review from penovicp June 29, 2023 07:13
@tabaktoni tabaktoni requested a review from ivpavici June 29, 2023 08:22
@tabaktoni tabaktoni merged commit 2410877 into develop Jun 29, 2023
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 5.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@penovicp penovicp deleted the eradicate-static-strings-v2 branch September 16, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penovicp penovicp penovicp approved these changes

@ivpavici ivpavici Awaiting requested review from ivpavici

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabaktoni @penovicp