Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: introduce calldata requestParser.test.ts #1224

Merged
merged 4 commits into from
Sep 13, 2024
Merged

chore: introduce calldata requestParser.test.ts #1224

merged 4 commits into from
Sep 13, 2024

Conversation

lukasaric
Copy link
Contributor

Motivation and Resolution

Cover calldata requestParser with tests

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@lukasaric lukasaric marked this pull request as draft September 12, 2024 06:45
@lukasaric lukasaric marked this pull request as ready for review September 12, 2024 10:22
ivpavici
ivpavici reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ivpavici ivpavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an @example on

export function parseCalldataField

🙏

tabaktoni
tabaktoni approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasaric
Copy link
Contributor Author

Can you please add an @example on

export function parseCalldataField

🙏

done ✅

@ivpavici ivpavici merged commit 7d61482 into starknet-io:develop Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabaktoni tabaktoni tabaktoni approved these changes

@ivpavici ivpavici ivpavici approved these changes

@penovicp penovicp penovicp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasaric @tabaktoni @ivpavici @penovicp