feat: num.toHex64 ensure 0x(64 char) format #1222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
approved these changes
Sep 16, 2024
Co-authored-by: Petar Penović <pp@spaceshard.io>
Co-authored-by: Petar Penović <pp@spaceshard.io>
ivpavici
reviewed
Sep 16, 2024
| * Similar as toStorageKey but conforming to exactly 0x(64 hex chars). | ||
| * | ||
| * @returns format: hex-0x(64)-string | ||
| */ |
There was a problem hiding this comment.
we are missing an @example here 🫶
| @@ -75,9 +76,23 @@ export const toHexString = toHex; | |||
| * @returns format: storage-key-string | |||
| */ | |||
| export function toStorageKey(number: BigNumberish): string { | |||
| // TODO: This is not completely correct as it will not enforce first 0 and second [0-7], 0x82bda... will pass as valid and should be false | |||
There was a problem hiding this comment.
also while we're at it, we could add a missing an @example here 🫶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
preparation for type gurading
Feat:
Usage related changes
Development related changes
Checklist: