Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Types & utils improvements #1212

Merged
merged 20 commits into from
Sep 5, 2024
Merged

Chore: Types & utils improvements #1212

merged 20 commits into from
Sep 5, 2024

Conversation

lukasaric
Copy link
Contributor

@lukasaric lukasaric commented Sep 2, 2024 •
edited
Loading

Motivation and Resolution

  • introduce typed util, which groups typeof like values checks (docs needs to be updated)
  • improve types overall (return types, interfaces etc)
  • remove url util
  • add assert.test.ts

It resolves: #1214

RPC version (if applicable)

Usage related changes

n.a

Development related changes

n.a

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@lukasaric lukasaric marked this pull request as draft September 2, 2024 09:11
@lukasaric lukasaric changed the title Chore/types improvements Chore: types improvements Sep 2, 2024
@lukasaric lukasaric changed the title Chore: types improvements Chore: Types & utils improvements Sep 3, 2024
@lukasaric lukasaric mentioned this pull request Sep 3, 2024
Merged
10 tasks
@lukasaric lukasaric marked this pull request as ready for review September 5, 2024 06:49
penovicp
penovicp reviewed Sep 5, 2024
View reviewed changes
src/utils/encode.ts Outdated Show resolved Hide resolved
src/utils/stark.ts Outdated Show resolved Hide resolved
src/utils/url.ts Show resolved Hide resolved
ivpavici
ivpavici reviewed Sep 5, 2024
View reviewed changes
src/utils/fetchPonyfill.ts Outdated Show resolved Hide resolved
ivpavici
ivpavici reviewed Sep 5, 2024
View reviewed changes
src/utils/fetchPonyfill.ts Outdated Show resolved Hide resolved
ivpavici
ivpavici reviewed Sep 5, 2024
View reviewed changes
src/utils/encode.ts Outdated Show resolved Hide resolved
@ivpavici ivpavici merged commit 453ad48 into starknet-io:develop Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivpavici ivpavici ivpavici approved these changes

@penovicp penovicp penovicp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types & utils improvements
3 participants
@lukasaric @ivpavici @penovicp