Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Popup): fix positioning in scrollable container #1341

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

layershifter
Copy link
Member

Fixes #1335.

Popper.JS relies on getScrollParent() function which recursively uses getParentNode() under hood. getParentNode() uses parentNode field and our ReferenceProxy doesn't have it before 😢

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #1341 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   72.31%   72.29%   -0.03%     
==========================================
  Files         762      762              
  Lines        5765     5767       +2     
  Branches     1711     1712       +1     
==========================================
  Hits         4169     4169              
- Misses       1590     1592       +2     
  Partials        6        6
Impacted Files Coverage Δ
...src/components/Popup/createPopperReferenceProxy.ts 38.46% <0%> (-7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4134ffe...b75e9e0. Read the comment docs.

@layershifter layershifter added 🧰 fix Introduces fix for broken behavior. 🚀 ready for review labels May 15, 2019
Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@layershifter layershifter merged commit 30b74fb into master May 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/popup-ref branch May 16, 2019 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup: positioning is broken inside overflow containers
2 participants