fix(Popup): fix positioning in scrollable container (#1341)

* fix(Popup): fix positioning in scrollable container * add CH entry
microsoft · May 16, 2019 · 30b74fb · 30b74fb
1 parent 4134ffe
commit 30b74fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 - Fixed `Flex.Item` children prop type @mnajdova ([#1320](https://github.com/stardust-ui/react/pull/1320))
 - Fixed `Icon`'s color example to align with the latest color updates @mnajdova ([#1336](https://github.com/stardust-ui/react/pull/1336))
 - Fixed `TreeTitle` - `tabIndex` prop should be camel case in behavior @sophieH29 ([#1345](https://github.com/stardust-ui/react/pull/1345))
+- Fixed handle refs on updates of `innerRef` prop in `Ref` component @layershifter ([#1331](https://github.com/stardust-ui/react/pull/1331))
+- Fixed positioing of `Popup` in scrollable container @layershifter ([#1341](https://github.com/stardust-ui/react/pull/1341))
 
 ### Features
 - Add `selected`, `isFromKeyboard` props to `DropdownItem` @mnajdova ([#1299](https://github.com/stardust-ui/react/pull/1299))

diff --git a/packages/react/src/components/Popup/createPopperReferenceProxy.ts b/packages/react/src/components/Popup/createPopperReferenceProxy.ts
@@ -21,6 +21,15 @@ class ReferenceProxy implements PopperJS.ReferenceObject {
   get clientHeight() {
     return this.getBoundingClientRect().height
   }
+
+  /**
+   * Required to allow properly finding a node to attach scroll.
+   *
+   * @see https://github.com/FezVrasta/popper.js/blob/v1.15.0/packages/popper/src/utils/getParentNode.js#L12
+   */
+  get parentNode() {
+    return this.ref.current ? this.ref.current.parentNode : undefined
+  }
 }
 
 /**