This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(doc): Maximize link points to children or shorthand example #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding on what is displayed
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
August 23, 2018 08:20
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 47 47
Lines 776 776
Branches 103 103
=======================================
Hits 691 691
Misses 83 83
Partials 2 2 Continue to review full report at Codecov.
|
kuzhelov
reviewed
Aug 23, 2018
@@ -649,7 +653,7 @@ class ComponentExample extends React.PureComponent<IComponentExampleProps, IComp | |||
<div style={{ flex: '0 0 auto' }}> | |||
<ComponentControls | |||
anchorName={this.anchorName} | |||
examplePath={examplePath} | |||
examplePath={currentExamplePath || examplePath} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for the sake of eliminating this a bit confusing expression (in a sense that it is not immediately evident what is the difference between these two), we could use
<ComponentControls
...
examplePath = {this.sourceCodeMgr.currentPath}
... />
and eliminate currentExamplePath
from all places - as this.sourceCodeMgr
already serves as state manager, and state updates are called on path change
kuzhelov
added
needs author feedback
Author's opinion is asked
and removed
🚀 ready for review
labels
Aug 23, 2018
miroslavstastny
added
🚀 ready for review
and removed
needs author feedback
Author's opinion is asked
labels
Aug 28, 2018
kuzhelov
approved these changes
Aug 28, 2018
This was referenced Mar 11, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs - Maximize button
Maximize button for an example in docs was always linked to children API. It was not possible to maximize shorthand example, maximize failed with 404 for examples which have shorthand impl only.
Now it links to the implementation (shorthand or children API) which is currently displayed.
TODO