Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix color for dropdown checkable indicator in hc theme #20621

Merged

Conversation

annabratseiko
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Update color of checkable indicator for dropdown items on hover in high contrast theme:

before:
image

after:
image

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff2704b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 16, 2021

📊 Bundle size report

🤖 This report was generated against d888426da44609c65dc720f708b8aadc70611410

@size-auditor
Copy link

size-auditor bot commented Nov 16, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d888426da44609c65dc720f708b8aadc70611410 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 16, 2021

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Dialog mount 2666 1419 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 973 989 5000
BaseButton mount 942 960 5000
Breadcrumb mount 2705 2684 1000
ButtonNext mount 542 528 5000
Checkbox mount 1551 1588 5000
CheckboxBase mount 1309 1316 5000
ChoiceGroup mount 4915 4866 5000
ComboBox mount 987 1017 1000
CommandBar mount 10566 10732 1000
ContextualMenu mount 8757 8871 1000
DefaultButton mount 1177 1174 5000
DetailsRow mount 3907 3815 5000
DetailsRowFast mount 3893 3841 5000
DetailsRowNoStyles mount 3753 3697 5000
Dialog mount 2666 1419 1000 Possible regression
DocumentCardTitle mount 170 165 1000
Dropdown mount 3324 3276 5000
FluentProviderNext mount 4214 4203 5000
FluentProviderWithTheme mount 233 238 10
FluentProviderWithTheme virtual-rerender 112 114 10
FluentProviderWithTheme virtual-rerender-with-unmount 281 274 10
FocusTrapZone mount 1835 1900 5000
FocusZone mount 1852 1897 5000
IconButton mount 1799 1808 5000
Label mount 373 363 5000
Layer mount 3068 3126 5000
Link mount 494 499 5000
MakeStyles mount 1868 1837 50000
MenuButton mount 1514 1528 5000
MessageBar mount 2065 2154 5000
Nav mount 3425 3445 1000
OverflowSet mount 1151 1149 5000
Panel mount 2595 2562 1000
Persona mount 887 865 1000
Pivot mount 1474 1469 1000
PrimaryButton mount 1318 1308 5000
Rating mount 7975 7926 5000
SearchBox mount 1357 1371 5000
Shimmer mount 2562 2571 5000
Slider mount 1993 2038 5000
SpinButton mount 5145 5139 5000
Spinner mount 449 432 5000
SplitButton mount 3263 3233 5000
Stack mount 521 526 5000
StackWithIntrinsicChildren mount 1726 1669 5000
StackWithTextChildren mount 4730 4766 5000
SwatchColorPicker mount 10686 10831 5000
TagPicker mount 2734 2803 5000
TeachingBubble mount 13726 13684 5000
Text mount 449 442 5000
TextField mount 1397 1448 5000
ThemeProvider mount 1246 1219 5000
ThemeProvider virtual-rerender 629 613 5000
ThemeProvider virtual-rerender-with-unmount 1943 1963 5000
Toggle mount 843 869 5000
buttonNative mount 152 144 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 407 376 1.08:1
AlertMinimalPerf.default 286 273 1.05:1
AttachmentSlotsPerf.default 1135 1084 1.05:1
DropdownManyItemsPerf.default 738 711 1.04:1
CardMinimalPerf.default 564 545 1.03:1
FlexMinimalPerf.default 311 302 1.03:1
GridMinimalPerf.default 353 344 1.03:1
ListMinimalPerf.default 538 523 1.03:1
TreeMinimalPerf.default 837 815 1.03:1
ButtonSlotsPerf.default 576 562 1.02:1
ChatDuplicateMessagesPerf.default 321 315 1.02:1
DatepickerMinimalPerf.default 5773 5658 1.02:1
DividerMinimalPerf.default 364 358 1.02:1
ListNestedPerf.default 578 566 1.02:1
RadioGroupMinimalPerf.default 472 464 1.02:1
ReactionMinimalPerf.default 384 375 1.02:1
ChatWithPopoverPerf.default 395 393 1.01:1
DropdownMinimalPerf.default 3286 3246 1.01:1
HeaderSlotsPerf.default 768 758 1.01:1
LayoutMinimalPerf.default 382 378 1.01:1
MenuMinimalPerf.default 891 880 1.01:1
MenuButtonMinimalPerf.default 1706 1685 1.01:1
ProviderMergeThemesPerf.default 1790 1779 1.01:1
SplitButtonMinimalPerf.default 4344 4313 1.01:1
VideoMinimalPerf.default 671 667 1.01:1
AvatarMinimalPerf.default 206 207 1:1
CarouselMinimalPerf.default 481 483 1:1
ChatMinimalPerf.default 675 673 1:1
CheckboxMinimalPerf.default 2793 2800 1:1
DialogMinimalPerf.default 775 774 1:1
PopupMinimalPerf.default 615 615 1:1
RefMinimalPerf.default 243 243 1:1
SegmentMinimalPerf.default 357 356 1:1
SkeletonMinimalPerf.default 362 363 1:1
StatusMinimalPerf.default 700 698 1:1
IconMinimalPerf.default 645 642 1:1
TableManyItemsPerf.default 1928 1922 1:1
TableMinimalPerf.default 417 416 1:1
CustomToolbarPrototype.default 4287 4291 1:1
ToolbarMinimalPerf.default 979 979 1:1
TooltipMinimalPerf.default 1066 1062 1:1
ButtonOverridesMissPerf.default 1822 1843 0.99:1
EmbedMinimalPerf.default 4383 4416 0.99:1
ImageMinimalPerf.default 386 389 0.99:1
ListWith60ListItems.default 663 672 0.99:1
ProviderMinimalPerf.default 1183 1199 0.99:1
SliderMinimalPerf.default 1745 1760 0.99:1
AccordionMinimalPerf.default 158 161 0.98:1
AnimationMinimalPerf.default 412 419 0.98:1
InputMinimalPerf.default 1332 1360 0.98:1
ItemLayoutMinimalPerf.default 1225 1251 0.98:1
LabelMinimalPerf.default 386 392 0.98:1
TextMinimalPerf.default 347 354 0.98:1
FormMinimalPerf.default 408 419 0.97:1
ListCommonPerf.default 637 658 0.97:1
LoaderMinimalPerf.default 711 731 0.97:1
PortalMinimalPerf.default 184 189 0.97:1
TextAreaMinimalPerf.default 492 508 0.97:1
AttachmentMinimalPerf.default 155 163 0.95:1
BoxMinimalPerf.default 351 369 0.95:1
RosterPerf.default 1167 1229 0.95:1
ButtonMinimalPerf.default 179 205 0.87:1
TreeWith60ListItems.default 180 214 0.84:1

@layershifter layershifter enabled auto-merge (squash) November 16, 2021 15:37
@layershifter layershifter merged commit f8113b8 into microsoft:master Nov 16, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* fix color for dropdown checkable indicator for hc theme

* update changelog

* update changelog

* update dropdown styles

Co-authored-by: Anna Kellerstein <annkelle@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants