-
Notifications
You must be signed in to change notification settings - Fork 2
feat(docs): improve examples clarity and styling #62
Conversation
…iew of code editor with extra "Click to edit" button
bdf37a0
to
e07d43c
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 70 70
Lines 1133 1133
Branches 194 215 +21
=======================================
Hits 790 790
Misses 338 338
Partials 5 5 Continue to review full report at Codecov.
|
…iew of code editor with extra "Click to edit" button
…ardust-ui/stardust into feat/improve-examples-clarity
… feat/improve-examples-clarity
Let's break this PR down to help move it forward:
@alinais can you ensure these are tracked for us in the Doc Site requirement please? |
…es and showing previews of component examples and rendered HTML
… feat/improve-examples-clarity
… feat/improve-examples-clarity
@levithomason |
@kuzhelov - thanks for reviewing, in reply to your comments:
both the way the gradients and the name of the label were the established requirement as per discussion with @levithomason ; I don't mind doing the changes as I don't have any strong preference here and to me it doesn't seem that different from user POV; @levithomason , what do u think?
so you're saying we should add the hover behavior even when the user is not hovering? the change also includes a background color change from a previous PR
|
actually, it sort of - the card should be visually separated from the other ones, and it is hard to achieve if we have a boundary built by white and light-grey colors. So, my suggestion was to apply Speaking of the first point - agree, lets sync up with @levithomason on that |
got it; I have prepared a change with the following styles: boxShadow: '0 0 15px #ccc',
...(isActive
? {
boxShadow: '0 0 40px #aaa',
}
: isHovering && {
boxShadow: '0 0 30px #aaa',
zIndex: 1,
}), DEMO |
Since @levithomason did not provide any input, I went with @kuzhelov 's suggestions and pushed a commit to address them
Here's updated:
@kuzhelov - can you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, introduce necessary changes to CHANGELOG.md - otherwise looks good to me 👍
… feat/improve-examples-clarity
- added to CHANGELOG.md
Added equal padding and changes to CHANGELOG.md |
Various improvements for the docs examples:
Short demo
Screenshots:
1. Before:
2. After: