Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(SDK): fix pipeline batch size return error #3134

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working sdk 🐶 labels Jan 31, 2024
@tianweidut tianweidut self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (411c05d) 82.99% compared to head (abee458) 92.22%.

Files Patch % Lines
client/starwhale/api/_impl/evaluation/pipeline.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3134      +/-   ##
============================================
+ Coverage     82.99%   92.22%   +9.22%     
============================================
  Files           575      139     -436     
  Lines         32293    16268   -16025     
  Branches       1895        0    -1895     
============================================
- Hits          26803    15003   -11800     
+ Misses         4656     1265    -3391     
+ Partials        834        0     -834     
Flag Coverage Δ
console ?
controller ?
standalone 92.22% <80.00%> (-0.03%) ⬇️
unittests 92.22% <80.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit e8ec3fd into star-whale:main Jan 31, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working sdk 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants