Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support echo @starwhale.argument help text #3101

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

tianweidut
Copy link
Member

Description

image
image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e6a498b) 82.71% compared to head (5e82a4e) 91.87%.

Files Patch % Lines
client/starwhale/core/model/view.py 30.00% 7 Missing ⚠️
client/starwhale/api/_impl/argument.py 94.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3101      +/-   ##
============================================
+ Coverage     82.71%   91.87%   +9.16%     
============================================
  Files           575      139     -436     
  Lines         32088    16288   -15800     
  Branches       1865        0    -1865     
============================================
- Hits          26540    14964   -11576     
+ Misses         4723     1324    -3399     
+ Partials        825        0     -825     
Flag Coverage Δ
console ?
controller ?
standalone 91.87% <80.85%> (+0.02%) ⬆️
unittests 91.87% <80.85%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 2ce80aa into star-whale:main Jan 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants