fix(evaluate): fix evaluate dict merge for pydantic #1490
+54
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavsinghvi11
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks @MSNP1381 ! left some minor comments to avoid extraneous changes togpt3.py but the changes to evaluate LGTM
| from dsp.utils.settings import settings | ||
|
|
||
|
|
||
| def is_module_installed(module_name): |
There was a problem hiding this comment.
just curious why this is needed. does the try/except block not take care of this check if langfuse is not supported?
dsp/modules/gpt3.py
Outdated
| @@ -111,6 +122,11 @@ def __init__( | |||
| def _openai_client(self): | |||
| return openai | |||
|
|
|||
| # TODO: add test suite to me. | |||
i just added the code comments but the merge function is unstable be cause there is varying type of output for modules. My opinion is either we just use pydantic Object or any inherited objects or user have to follow some basic interfaces (as simple as dict interface)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it had error when your module's output was a pydantic object rather that a dict