feat(dspy): Add input for AWS credentials for AWSProvider, Bedrock and Sagemaker class #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp/modules/aws_providers.py
Outdated
| from dsp.utils.settings import settings | ||
|
|
||
| try: | ||
| import boto3 | ||
| boto3_spec = importlib.util.find_spec("boto3") |
There was a problem hiding this comment.
I think the previous try-except logic suffices? fine to merge after reverting back this logic
There was a problem hiding this comment.
Hello @arnavsinghvi11. I reversed the logic as you suggested but it was necessary to remove the boto3 import here because ruff was failing. We are already importing boto3 in the AWSProvider class constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the AWSProvider, Bedrock, and Sagemaker classes by adding the capability to input AWS credentials directly. This update provides greater flexibility beyond using the a profile within the AWS credentials file.
Motivation:
The primary goal of this update is to increase flexibility in managing AWS credentials.