Add --disable-cache flag #2143
Merged
Add --disable-cache flag #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
reviewed
Dec 14, 2023
| return None | ||
|
|
||
| def get_all(self) -> Generator[Tuple[Dict, Dict], None, None]: | ||
| return |
There was a problem hiding this comment.
This return shouldn't be there?
There was a problem hiding this comment.
return
yieldis actually correct and typechecks, as explained here. yield alone fails typechecking. Also, mypy is okay with this version, whereas the alternatives suggested in the link fail mypy typechecking.
yifanmai
force-pushed
the
yifanmai/fix-disable-cache
branch
from
08ffd4c
to
a6fc79a
Compare
|
@percyliang This is ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2016
Addresses #1914