Added special case to support Anthropic Critique #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanmai
changed the title
yifanmai
approved these changes
Sep 26, 2023
| @@ -14,6 +14,8 @@ | |||
| from helm.proxy.clients.client import Client | |||
| from helm.proxy.clients.critique_client import CritiqueClient | |||
|
|
|||
| import anthropic | |||
There was a problem hiding this comment.
Handle anthropic as an optional dependency like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to support Claude in
CritiqueModel.I say quick but at the same time I don't think there is a super clean way to handle this for now. We could add the notion of prefix and suffix to the
CritiqueModelClientbut this would still require this logic somewhere. I think this should be handled further down the line by our refactor which would add automatically the correct prefix and suffix for a model.